linux-kernel - Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5e2ff07-fe29-4ff1-abc8-7250c756154e@linaro.org>
Date: Sun, 7 Jan 2024 11:35:13 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Karel Balej <karelb@...li.ms.mff.cuni.cz>, Karel Balej
 <balejk@...fyz.cz>, Lee Jones <lee@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Duje Mihanović <duje.mihanovic@...le.hr>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

On 28/12/2023 10:39, Karel Balej wrote:
> diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c
> index 69a8e39d43b3..999d0539b720 100644
> --- a/drivers/mfd/88pm88x.c
> +++ b/drivers/mfd/88pm88x.c
> @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = {
>  		.num_resources = ARRAY_SIZE(pm88x_onkey_resources),
>  		.resources = pm88x_onkey_resources,
>  	},
> +	{
> +		.name = "88pm88x-regulator",
> +		.id = PM88X_REGULATOR_ID_LDO2,
> +		.of_compatible = "marvell,88pm88x-regulator",
> +	},
> +	{
> +		.name = "88pm88x-regulator",
> +		.id = PM88X_REGULATOR_ID_LDO15,
> +		.of_compatible = "marvell,88pm88x-regulator",
> +	},
> +	{
> +		.name = "88pm88x-regulator",
> +		.id = PM886_REGULATOR_ID_BUCK2,
> +		.of_compatible = "marvell,88pm88x-regulator",

Same compatible per each regulator looks suspicious, if not even wrong.
What are these?

Best regards,
Krzysztof