lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Jan 2024 20:29:57 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christoph Winklhofer <cj.winklhofer@...il.com>,
 Jiri Slaby <jirislaby@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Jonathan Corbet <corbet@....net>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 3/3] w1: add UART w1 bus driver

On 08/01/2024 19:03, Christoph Winklhofer wrote:
> ...
>>> +static int w1_uart_serdev_receive_buf(struct serdev_device *serdev,
>>> +				      const unsigned char *buf, size_t count)
>>
>> serdev already uses u8 * here. You are basing on the top of some old tree.

Old? Your change came for v6.8 and this was sent when all trees were
based on v6.7-rc1. What newer tree could have this been?

> Yes, this patch is based on the w1-next branch of
>   git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git
> was not sure from where to start. I guess that this change is probably in
> the w1-tree after the next stable release.

That's a timing issue. For that particular case, where this was
targeting next-next cycle, you should have based this on linux-next. In
other cases this would require cross-tree merging due to dependencies
which none of us were aware, so no harm.


Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ