linux-kernel - Re: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whkGHOmpM_1kNgzX1UDAs10+UuALcpeEWN29EE0m-my=w@mail.gmail.com>
Date: Mon, 8 Jan 2024 13:11:12 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Jiri Slaby <jirislaby@...il.com>
Cc: David Laight <David.Laight@...lab.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
	Christoph Hellwig <hch@...radead.org>, "Jason A. Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

On Mon, 8 Jan 2024 at 12:04, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> So we *could* plan on that, remove the checks from min/max, and use
> something like the attached patch.

Whee.

On my machine, that patch makes an "allmodconfig" build go from

    10:41 elapsed

to

     8:46 elapsed

so that min/max type checking is almost 20% of the build time.

Yeah, I think we need to get rid of it.

Can somebody else confirm similar time differences? Or is it just me?

                 Linus