linux-kernel - Re: [PATCH] drm/ci: Add msm tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <454873e5-1b5a-28d3-ffed-c1e502898d17@quicinc.com>
Date: Mon, 8 Jan 2024 14:58:16 -0800
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Rob Clark <robdclark@...il.com>, <dri-devel@...ts.freedesktop.org>
CC: <freedreno@...ts.freedesktop.org>, <linux-arm-msm@...r.kernel.org>,
        Rob
 Clark <robdclark@...omium.org>,
        Helen Koike <helen.koike@...labora.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/ci: Add msm tests



On 1/8/2024 11:50 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
> 
> The msm tests should skip on non-msm hw, so I think it should be safe to
> enable everywhere.
> 
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> ---
>   drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
> 

I do see that all these tests use igt_msm_dev_open() to make sure it 
opens only the MSM card.

But if igt_msm_dev_open() fails, I dont see a igt_require() on some of 
the tests to skip them. So how will it safely skip on non-msm HW?

Unless i am missing something here ....

> diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt
> index f82cd90372f4..eaeb751bb0ad 100644
> --- a/drivers/gpu/drm/ci/testlist.txt
> +++ b/drivers/gpu/drm/ci/testlist.txt
> @@ -2910,3 +2910,52 @@ kms_writeback@...teback-invalid-parameters
>   kms_writeback@...teback-fb-id
>   kms_writeback@...teback-check-output
>   prime_mmap_kms@...fer-sharing
> +msm_shrink@...y-gpu-sanitycheck-8
> +msm_shrink@...y-gpu-sanitycheck-32
> +msm_shrink@...y-gpu-8
> +msm_shrink@...y-gpu-32
> +msm_shrink@...y-gpu-madvise-8
> +msm_shrink@...y-gpu-madvise-32
> +msm_shrink@...y-gpu-oom-8
> +msm_shrink@...y-gpu-oom-32
> +msm_shrink@...y-mmap-sanitycheck-8
> +msm_shrink@...y-mmap-sanitycheck-32
> +msm_shrink@...y-mmap-8
> +msm_shrink@...y-mmap-32
> +msm_shrink@...y-mmap-madvise-8
> +msm_shrink@...y-mmap-madvise-32
> +msm_shrink@...y-mmap-oom-8
> +msm_shrink@...y-mmap-oom-32
> +msm_shrink@...y-mmap-dmabuf-sanitycheck-8
> +msm_shrink@...y-mmap-dmabuf-sanitycheck-32
> +msm_shrink@...y-mmap-dmabuf-8
> +msm_shrink@...y-mmap-dmabuf-32
> +msm_shrink@...y-mmap-dmabuf-madvise-8
> +msm_shrink@...y-mmap-dmabuf-madvise-32
> +msm_shrink@...y-mmap-dmabuf-oom-8
> +msm_shrink@...y-mmap-dmabuf-oom-32
> +msm_mapping@...g
> +msm_mapping@...fw
> +msm_mapping@...dow
> +msm_submitoverhead@...mitbench-10-bos
> +msm_submitoverhead@...mitbench-10-bos-no-implicit-sync
> +msm_submitoverhead@...mitbench-100-bos
> +msm_submitoverhead@...mitbench-100-bos-no-implicit-sync
> +msm_submitoverhead@...mitbench-250-bos
> +msm_submitoverhead@...mitbench-250-bos-no-implicit-sync
> +msm_submitoverhead@...mitbench-500-bos
> +msm_submitoverhead@...mitbench-500-bos-no-implicit-sync
> +msm_submitoverhead@...mitbench-1000-bos
> +msm_submitoverhead@...mitbench-1000-bos-no-implicit-sync
> +msm_recovery@...gcheck
> +msm_recovery@...-fault
> +msm_recovery@...-fault-parallel
> +msm_recovery@...a-fault
> +msm_submit@...ty-submit
> +msm_submit@...alid-queue-submit
> +msm_submit@...alid-flags-submit
> +msm_submit@...alid-in-fence-submit
> +msm_submit@...alid-duplicate-bo-submit
> +msm_submit@...alid-cmd-idx-submit
> +msm_submit@...alid-cmd-type-submit
> +msm_submit@...id-submit