linux-kernel - RE: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB4734F1FC933FC4E4BAB06934C76B2@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Mon, 8 Jan 2024 09:40:07 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani
	<hgani@...vell.com>, Vimlesh Kumar <vimleshk@...vell.com>,
        Sathesh B Edara
	<sedara@...vell.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        "pabeni@...hat.com"
	<pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "kheib@...hat.com"
	<kheib@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Satananda Burla
	<sburla@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool
 support

Thanks for your review. Will submit V4 soon

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, January 6, 2024 9:03 AM
> To: Shinas Rasheed <srasheed@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Haseeb Gani
> <hgani@...vell.com>; Vimlesh Kumar <vimleshk@...vell.com>; Sathesh B
> Edara <sedara@...vell.com>; egallen@...hat.com; mschmidt@...hat.com;
> pabeni@...hat.com; horms@...nel.org; wizhao@...hat.com;
> kheib@...hat.com; konguyen@...hat.com; Veerasenareddy Burru
> <vburru@...vell.com>; Satananda Burla <sburla@...vell.com>; David S.
> Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>
> Subject: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, 5 Jan 2024 12:38:22 -0800 Shinas Rasheed wrote:
> > +	"rx_dropped",
> > +	"tx_dropped",
> 
> Please take a close look at rtnl_link_stats64.
> Anything that fits should really go to standard interface stats.
> This will benefit the piles of monitoring SW which gather standard
> stats.
> 
> > +	"rx_dropped_pkts_fifo_full",
> 
> This one is probably rx_missed_errors