[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ca08b91-a950-43cc-946a-932afd855f9a@linaro.org>
Date: Mon, 8 Jan 2024 11:07:42 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ritesh Kumar <quic_riteshk@...cinc.com>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, sam@...nborg.org,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, daniel@...ll.ch, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
quic_abhinavk@...cinc.com, quic_rajeevny@...cinc.com,
quic_vproddut@...cinc.com, sumit.semwal@...aro.org
Subject: Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD
DSI
On 08/01/2024 10:59, Ritesh Kumar wrote:
> Document Novatek NT36672E FHD+ LCD DSI panel.
>
> Signed-off-by: Ritesh Kumar <quic_riteshk@...cinc.com>
>
> ---
> v2: Fixed review comments from Krzysztof
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.
> - renamed to novatek,nt36672e, since the binding is for the IC and
> not the panel.
> - moved additionalProperties after required.
> ---
> .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> new file mode 100644
> index 000000000000..dc4672f3d01d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36672E LCD DSI Panel
> +
> +maintainers:
> + - Ritesh Kumar <quic_riteshk@...cinc.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: novatek,nt36672e
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + vddi-supply: true
> + avdd-supply: true
> + avee-supply: true
Are these names of pins? Somehow I have troubles believing that NT36672A
and NT36672E have entirely different names for these...
Best regards,
Krzysztof
Powered by blists - more mailing lists