linux-kernel - [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Mon,  8 Jan 2024 18:14:02 +0800
From: Minjie Du <duminjie@...o.com>
To: David Howells <dhowells@...hat.com>,
	linux-cachefs@...hat.com (moderated list:FILESYSTEMS [NETFS LIBRARY]),
	linux-fsdevel@...r.kernel.org (open list:FILESYSTEMS [NETFS LIBRARY]),
	linux-kernel@...r.kernel.org (open list)
Cc: opensource.kernel@...o.com,
	Minjie Du <duminjie@...o.com>
Subject: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_volume()

key might contain private information, so use kfree_sensitive to free it.
In fscache_free_volume() use kfree_sensitive().

Signed-off-by: Minjie Du <duminjie@...o.com>
---
 fs/netfs/fscache_volume.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/netfs/fscache_volume.c b/fs/netfs/fscache_volume.c
index cdf991bdd9de..648a7d6eaa6a 100644
--- a/fs/netfs/fscache_volume.c
+++ b/fs/netfs/fscache_volume.c
@@ -397,7 +397,7 @@ static void fscache_free_volume(struct fscache_volume *volume)
 		fscache_unhash_volume(volume);
 
 	trace_fscache_volume(volume->debug_id, 0, fscache_volume_free);
-	kfree(volume->key);
+	kfree_sensitive(volume->key);
 	kfree(volume);
 	fscache_stat_d(&fscache_n_volumes);
 	fscache_put_cache(cache, fscache_cache_put_volume);
-- 
2.39.0