[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3yoesok4yzvc565hmlbj4ybdihhzsofqsnpx3bnzg2phlbq3zf@55jn4zo24vvv>
Date: Mon, 8 Jan 2024 11:52:01 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Michał Winiarski <michal.winiarski@...el.com>
Cc: intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, Rodrigo Vivi <rodrigo.vivi@...el.com>,
Michal Wajdeczko <michal.wajdeczko@...el.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Javier Martinez Canillas <javierm@...hat.com>,
Maíra Canal <mcanal@...lia.com>
Subject: Re: [PATCH v4 5/6] drm/tests: managed: Extract device initialization
into test init
On Fri, Jan 05, 2024 at 11:13:23AM +0100, Michał Winiarski wrote:
> It simplifies the process of extending the test suite with additional
> test cases without unnecessary duplication.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@...el.com>
> ---
> drivers/gpu/drm/tests/drm_managed_test.c | 37 +++++++++++++++---------
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c
> index 986a38c9144a5..c1fc1f0aac9b2 100644
> --- a/drivers/gpu/drm/tests/drm_managed_test.c
> +++ b/drivers/gpu/drm/tests/drm_managed_test.c
> @@ -9,6 +9,7 @@
> #include <linux/device.h>
>
> struct managed_test_priv {
> + struct drm_device *drm;
> bool action_done;
> };
>
> @@ -24,11 +25,26 @@ static void drm_action(struct drm_device *drm, void *ptr)
> * device is released.
> */
> static void drm_test_managed_run_action(struct kunit *test)
> +{
> + struct managed_test_priv *priv = test->priv;
> + int ret;
> +
> + ret = drmm_add_action_or_reset(priv->drm, drm_action, priv);
> + KUNIT_EXPECT_EQ(test, ret, 0);
> +
> + ret = drm_dev_register(priv->drm, 0);
> + KUNIT_ASSERT_EQ(test, ret, 0);
> +
> + drm_dev_unregister(priv->drm);
> + drm_kunit_helper_free_device(test, priv->drm->dev);
> +
> + KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called");
Aside from the message here I already pointed out,
Acked-by: Maxime Ripard <mripard@...nel.org>
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists