linux-kernel - Re: fs/9p: Improve exception handling in v9fs_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f97521ef-0600-401a-8fdb-9648d576ea4c@web.de>
Date: Mon, 8 Jan 2024 13:15:43 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Dominique Martinet <asmadeus@...ewreck.org>,
 Eric Van Hensbergen <ericvh@...nel.org>, v9fs@...ts.linux.dev,
 kernel-janitors@...r.kernel.org
Cc: Christian Schönebeck <linux_oss@...debyte.com>,
 Latchesar Ionkov <lucho@...kov.net>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: fs/9p: Improve exception handling in v9fs_session_init()

>> The kfree() function was called in up to two cases by
>> the v9fs_session_init() function during error handling
>> even if the passed variable contained a null pointer.
>
> I don't see the problem in calling kfree on null things (especially on
> error path).

Will you become willing to reduce the number of redundant function calls
for improved exception handling?

Regards,
Markus