linux-kernel - Re: [PATCH v3 2/3] x86/mm: Regularize set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Jan 2024 16:10:34 +0300
From: kirill.shutemov@...ux.intel.com
To: mhklinux@...look.com
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
	luto@...nel.org, peterz@...radead.org, akpm@...ux-foundation.org,
	urezki@...il.com, hch@...radead.org, lstoakes@...il.com,
	thomas.lendacky@....com, ardb@...nel.org, jroedel@...e.de,
	seanjc@...gle.com, rick.p.edgecombe@...el.com,
	sathyanarayanan.kuppuswamy@...ux.intel.com,
	linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev,
	linux-hyperv@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 2/3] x86/mm: Regularize set_memory_p() parameters and
 make non-static

On Fri, Jan 05, 2024 at 10:30:24AM -0800, mhkelley58@...il.com wrote:
> From: Michael Kelley <mhklinux@...look.com>
> 
> set_memory_p() is currently static.  It has parameters that don't
> match set_memory_p() under arch/powerpc and that aren't congruent
> with the other set_memory_* functions. There's no good reason for
> the difference.
> 
> Fix this by making the parameters consistent, and update the one
> existing call site.  Make the function non-static and add it to
> include/asm/set_memory.h so that it is completely parallel to
> set_memory_np() and is usable in other modules.
> 
> No functional change.
> 
> Signed-off-by: Michael Kelley <mhklinux@...look.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov