linux-kernel - Re: add DSD for ThinkBook 16p G4 IRH with Subsystem Id of :

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5pgt1bt.wl-tiwai@suse.de>
Date: Mon, 08 Jan 2024 14:13:42 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Huayu Zhang <932367230@...com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	james.schulman@...rus.com,
	david.rhodes@...rus.com,
	rf@...nsource.cirrus.com,
	perex@...ex.cz,
	sbinding@...nsource.cirrus.com,
	kailang@...ltek.com,
	zhanghuayu.dev@...il.com
Subject: Re: add DSD for ThinkBook 16p G4 IRH with Subsystem Id of :

On Mon, 08 Jan 2024 13:51:36 +0100,
Huayu Zhang wrote:
> 
> Sorry for missing the info within patch and not familiar with the
> mailing system using git. As mentioned in the subject,
> the patch is using to fix the sound issue of ThinkBook 16p G4 IRH with
> Subsystem Id of : 0x17aa38a9. But this just enable the downside (bass)
> speakers. When I tried to adjust the volumn, it atually mapped to the
> frequency division (the lower volumn actually set the bass speakers,
> and higher volumn map to the louder sound of up facing speakers).
> Wondering if this related to ALSA?

The amp behavior is a question to Cirrus people, I suppose.

In anyway, the patch can't be taken as is.  You need to submit the
patch in a more formal way.

- Correct the subject line with a proper prefix, e.g.
    [PATCH] ALSA: hda: Add DSD for ....
  When resubmitting with some changes, put the revision number, too,
    [PATCH v2] ALSA: hda: Add DSD for ....

- Give the proper patch description in the patch itself.

- Put your Signed-off-by line after the patch description.
  It's a legal requirement.

Please refer to Documentation/process/submitting-patches.rst for
details.


thanks,

Takashi