linux-kernel - Re: [PATCH v5 7/9] acpi/ghes: Process CXL Component Events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240108134157.0000013c@Huawei.com>
Date: Mon, 8 Jan 2024 13:41:57 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Ira Weiny <ira.weiny@...el.com>
CC: Dan Williams <dan.j.williams@...el.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@....com>, Shiju Jose <shiju.jose@...wei.com>,
	Yazen Ghannam <yazen.ghannam@....com>, "Davidlohr Bueso" <dave@...olabs.net>,
	Dave Jiang <dave.jiang@...el.com>, "Alison Schofield"
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, Ard
 Biesheuvel <ardb@...nel.org>, <linux-efi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-cxl@...r.kernel.org>, "Rafael J.
 Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v5 7/9] acpi/ghes: Process CXL Component Events

On Wed, 20 Dec 2023 16:17:34 -0800
Ira Weiny <ira.weiny@...el.com> wrote:

> BIOS can configure memory devices as firmware first.  This will send CXL
> events to the firmware instead of the OS.  The firmware can then send
> these events to the OS via UEFI.
> 
> UEFI v2.10 section N.2.14 defines a Common Platform Error Record (CPER)
> format for CXL Component Events.  The format is mostly the same as the
> CXL Common Event Record Format.  The difference is the use of a GUID in
> the Section Type rather than a UUID as part of the event itself.
> 
> Add GHES support to detect CXL CPER records and call a registered
> callback with the event.
> 
> A notifier chain was considered for the callback but the complexity did
> not justify the use case as only the CXL subsystem requires this event.
> Enforce that only one callback can be registered at any time.
> 
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> 

Very annoying that CXL using UUIDS and UEFI GUIDs (so endian swapped).

Is it worth a general conversion function or just keep the data duplication?

Otherwise LGTM

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>