linux-kernel - Re: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bf7da8b-6a0b-4c0d-959e-329d7cbd8cea@amd.com>
Date: Mon, 8 Jan 2024 10:01:48 -0600
From: Carlos Bilbao <carlos.bilbao@....com>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>,
 Elena Reshetova <elena.reshetova@...el.com>, Jonathan Corbet
 <corbet@....net>, linux-doc@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT
 MODEL section

Hello,

On 1/8/24 08:08, Lukas Bulwahn wrote:
> Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
> threat model for x86 virtualization") adds new documentation and a
> corresponding MAINTAINERS section. It however uses spaces instead of a
> single tab for all the entries in that MAINTAINERS section.
> 
> Although, the get_maintainer.pl script handles spaces instead of tabs
> silently, the MAINTAINERS will quickly get into a messy state with
> different indentations throughout the file. So, the checkpatch.pl script
> complains when spaces instead of a single tab are used.
> 
> Fix this recently added section using tabs instead of spaces.
> 
> Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Jakub has already addressed this issue with the patch "[PATCH docs]
MAINTAINERS: use tabs for indent of CONFIDENTIAL COMPUTING THREAT MODEL"
from 1/3/24. Also, I recommend refraining from using the 'Fixes' tag for
things of this nature. NACK.

> ---
>   MAINTAINERS | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e2624723..c76884e40434 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5296,10 +5296,10 @@ W:	http://accessrunner.sourceforge.net/
>   F:	drivers/usb/atm/cxacru.c
>   
>   CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
> -M:    Elena Reshetova <elena.reshetova@...el.com>
> -M:    Carlos Bilbao <carlos.bilbao@....com>
> -S:    Maintained
> -F:    Documentation/security/snp-tdx-threat-model.rst
> +M:	Elena Reshetova <elena.reshetova@...el.com>
> +M:	Carlos Bilbao <carlos.bilbao@....com>
> +S:	Maintained
> +F:	Documentation/security/snp-tdx-threat-model.rst
>   
>   CONFIGFS
>   M:	Joel Becker <jlbec@...lplan.org>

Thanks,
Carlos