linux-kernel - Re: [PATCH 2/2] ufs:mcq:Remove unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Jan 2024 09:32:39 -0800
From: Bart Van Assche <bvanassche@....org>
To: Chanwoo Lee <cw9316.lee@...sung.com>, alim.akhtar@...sung.com,
 avri.altman@....com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
 stanley.chu@...iatek.com, quic_cang@...cinc.com, mani@...nel.org,
 quic_asutoshd@...cinc.com, powen.kao@...iatek.com, quic_nguyenb@...cinc.com,
 yang.lee@...ux.alibaba.com, peter.wang@...iatek.com, athierry@...hat.com,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, dh0421.hwang@...sung.com,
 sh043.lee@...sung.com
Subject: Re: [PATCH 2/2] ufs:mcq:Remove unused parameters

On 1/4/24 18:10, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@...sung.com>
> 
> The 'hwq' parameter is not used in this function.
> So, remove unused parameters.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>
> ---
>   drivers/ufs/core/ufs-mcq.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index edc752e55878..8db81f1a12d5 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -258,9 +258,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_write_cqis);
>    * Current MCQ specification doesn't provide a Task Tag or its equivalent in
>    * the Completion Queue Entry. Find the Task Tag using an indirect method.
>    */
> -static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
> -				     struct ufs_hw_queue *hwq,
> -				     struct cq_entry *cqe)
> +static int ufshcd_mcq_get_tag(struct ufs_hba *hba, struct cq_entry *cqe)
>   {
>   	u64 addr;
>   
> @@ -278,7 +276,7 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba,
>   				   struct ufs_hw_queue *hwq)
>   {
>   	struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
> -	int tag = ufshcd_mcq_get_tag(hba, hwq, cqe);
> +	int tag = ufshcd_mcq_get_tag(hba, cqe);
>   
>   	if (cqe->command_desc_base_addr) {
>   		ufshcd_compl_one_cqe(hba, tag, cqe);

Reviewed-by: Bart Van Assche <bvanassche@....org>