lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Jan 2024 17:47:24 +0000
From: Elad Nachman <enachman@...vell.com>
To: Conor Dooley <conor@...nel.org>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5



> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: Monday, January 8, 2024 7:15 PM
> To: Elad Nachman <enachman@...vell.com>
> Cc: gregkh@...uxfoundation.org; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> devicetree@...r.kernel.org; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
> > From: Elad Nachman <enachman@...vell.com>
> >
> > Add Marvell ac5 device tree bindings to generic EHCI.
> > This compatible enables the Marvell Orion platform code to properly
> > configure the DMA mask for the Marvell AC5 SOC.
> >
> > Signed-off-by: Elad Nachman <enachman@...vell.com>
> 
> Maybe I am dumb, but I don't understand how this does what the commit
> message says. There's no fallback to generic-ehci or any other compatible
> that is already understood by the driver.
> 
> What am I missing?

Following guidance by Andrew Lunn on my mmc patchset, I have split the patchset
Into a single patch for dt-bindings review and another for USB driver review.

The USB driver patch utilizing this new dt bindings compatible string is here:

https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.3677347-1-enachman@marvell.com/

> 
> > ---
> >  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > index 87986c45be88..2ed178f16a78 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > @@ -77,6 +77,7 @@ properties:
> >            - const: usb-ehci
> >        - enum:
> >            - generic-ehci
> > +          - marvell,ac5-ehci
> >            - marvell,armada-3700-ehci
> >            - marvell,orion-ehci
> >            - nuvoton,npcm750-ehci
> > --
> > 2.25.1
> >

Elad.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ