linux-kernel - Re: [PATCH] of: Fix double free in of_parse_phandle_with_args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 12:58:53 -0600
From: Rob Herring <robh@...nel.org>
To: "Christian A. Ehrhardt" <lk@...e.de>
Cc: Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org, Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org, Stephen Boyd <stephen.boyd@...aro.org>
Subject: Re: [PATCH] of: Fix double free in of_parse_phandle_with_args_map


On Fri, 29 Dec 2023 11:54:11 +0100, Christian A. Ehrhardt wrote:
> In of_parse_phandle_with_args_map() the inner loop that
> iterates through the map entries calls of_node_put(new)
> to free the reference acquired by the previous iteration
> of the inner loop. This assumes that the value of "new" is
> NULL on the first iteration of the inner loop.
> 
> Make sure that this is true in all iterations of the outer
> loop by setting "new" to NULL after its value is assigned to "cur".
> 
> Extend the unittest to detect the double free and add an additional
> test case that actually triggers this path.
> 
> Fixes: bd6f2fd5a1 ("of: Support parsing phandle argument lists through a nexus node")
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Signed-off-by: Christian A. Ehrhardt <lk@...e.de>
> ---
>  drivers/of/base.c                           |  1 +
>  drivers/of/unittest-data/tests-phandle.dtsi | 10 ++-
>  drivers/of/unittest.c                       | 74 ++++++++++++---------
>  3 files changed, 53 insertions(+), 32 deletions(-)
> 

Applied, thanks!