linux-kernel - Re: [PATCH 1/2 net-next v2] bonding: Extending LACP MUX State Machine to include a Collecting State.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 11:06:56 -0800
From: Aahil Awatramani <aahila@...gle.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: Jay Vosburgh <jay.vosburgh@...onical.com>, David Dillow <dave@...dillows.org>, 
	Mahesh Bandewar <maheshb@...gle.com>, Andy Gospodarek <andy@...yhouse.net>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Martin KaFai Lau <martin.lau@...nel.org>, Herbert Xu <herbert@...dor.apana.org.au>, 
	Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 net-next v2] bonding: Extending LACP MUX State Machine
 to include a Collecting State.

Thank you folk for your feedback.

Currently due to travelling reasons there will be a slight delay in my updates
but this should be resolved soon and I should be able to provide quicker
iterative feedback.

Thank you again for your reviews,
Aahil

On Sun, Jan 7, 2024 at 7:46 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Thu, Jan 04, 2024 at 05:38:52PM -0800, Jay Vosburgh wrote:
> > >+coupled_control
> > >+
> > >+    Specifies whether the LACP state machine's MUX in the 802.3ad mode
> > >+    should have separate Collecting and Distributing states.
> > >+
> > >+    The default value is 1. This setting does not separate the Collecting
> > >+    and Distributing states, maintaining the bond in coupled control.
> > >+
> >
> >       Please reference the standard in the description; this is
> > implementing the independent control state machine per IEEE 802.1AX-2008
> > 5.4.15 in addition to the existing coupled control state machine.
>
> The status of IEEE 802.1AX-2008[1] is "Superseded Standard". Maybe we should
> use IEEE 802.1AX-2020[2].
>
> [1] https://standards.ieee.org/ieee/802.1AX/4176/
> [2] https://standards.ieee.org/ieee/802.1AX/6768/
>
> Thanks
> Hangbin