linux-kernel - Re: [PATCH] md: fix md_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 11:14:59 -0800
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] md: fix md_seq_ops() regressions

On Tue, Jan 9, 2024 at 5:43 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> Commit cf1b6d4441ff ("md: simplify md_seq_ops") introduce following
> regressions:
>
> 1) If list all_mddevs is emptly, personalities and unused devices won't
>    be showed to user anymore.
> 2) If seq_file buffer overflowed from md_seq_show(), then md_seq_start()
>    will be called again, hence personalities will be showed to user
>    again.
> 3) If seq_file buffer overflowed from md_seq_stop(), seq_read_iter()
>    doesn't handle this, hence unused devices won't be showed to user.
>
> Fix above problems by print personalities and unused devices in
> md_seq_show(), as it used to be.
>
> Fixes: cf1b6d4441ff ("md: simplify md_seq_ops")
>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.8 branch. (Yes, I am trying to make some changes to the
branches we use. )

Thanks,
Song