linux-kernel - Re: [PATCH v2 0/4] kselftest: alsa: Fix a couple of format specifiers and function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 20:23:33 +0100
From: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
To: Takashi Iwai <tiwai@...e.de>
Cc: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Mark Brown <broonie@...nel.org>, linux-sound@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v2 0/4] kselftest: alsa: Fix a couple of format specifiers
 and function parameters

On 1/9/2024 3:16 PM, Takashi Iwai wrote:
> On Sun, 07 Jan 2024 18:37:00 +0100,
> Mirsad Todorovac wrote:
>>
>> Minor fixes of compiler warnings and one bug in the number of parameters which
>> would not crash the test but it is better fixed for correctness sake.
>>
>> As the general climate in the Linux kernel community is to fix all compiler
>> warnings, this could be on the right track, even if only in the testing suite.
>>
>> Changelog:
>>
>> v1 -> v2:
>> - Compared to v1, commit subject lines have been adjusted to reflect the style
>>    of the subsystem, as suggested by Mark.
>> - 1/4 was already acked and unchanged (adjusted the subject line as suggested)
>>    (code unchanged)
>> - 2/4 was acked with suggestion to adjust the subject line (done).
>>    (code unchanged)
>> - 3/4 The format specifier was changed from %d to %u as suggested.
>> - The 4/4 submitted for review (in the v1 it was delayed by an omission).
>>    (code unchanged)
>>
>> Mirsad Todorovac (4):
>>    kselftest/alsa - mixer-test: fix the number of parameters to
>>      ksft_exit_fail_msg()
>>    kselftest/alsa - mixer-test: Fix the print format specifier warning
>>    kselftest/alsa - mixer-test: Fix the print format specifier warning
>>    kselftest/alsa - conf: Stringify the printed errno in sysfs_get()
> 
> Applied all patches now.  Thanks.
> 
> 
> Takashi

No, thanks to you for your patient work. I realise that there are roughly
2,000 patch emails each day.

This might seem like sugarcoating, but I realise the developers are under
a great stress having to evaluate such number of patches each day. The kernel
is now close to 35+ Mlines and I do not underestimate this work.

I'm nowhere close to understanding all subsystems, but I recognise the need
to be disciplined to make the maintainer's job easier and feasible in the
long run.

The time invested in the Linux kernel and operating system is a gift that
keeps on giving :-)

Regards,
Mirsad

-- 
Mirsad Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355