linux-kernel - Re: [PATCH v10 07/50] x86/sev: Add RMP entry lookup helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240109220746.GAZZ3DsouxpiUPeBVN@fat_crate.local>
Date: Tue, 9 Jan 2024 23:07:46 +0100
From: Borislav Petkov <bp@...en8.de>
To: Michael Roth <michael.roth@....com>
Cc: kvm@...r.kernel.org, linux-coco@...ts.linux.dev, linux-mm@...ck.org,
	linux-crypto@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	jroedel@...e.de, thomas.lendacky@....com, hpa@...or.com,
	ardb@...nel.org, pbonzini@...hat.com, seanjc@...gle.com,
	vkuznets@...hat.com, jmattson@...gle.com, luto@...nel.org,
	dave.hansen@...ux.intel.com, slp@...hat.com, pgonda@...gle.com,
	peterz@...radead.org, srinivas.pandruvada@...ux.intel.com,
	rientjes@...gle.com, dovmurik@...ux.ibm.com, tobin@....com,
	vbabka@...e.cz, kirill@...temov.name, ak@...ux.intel.com,
	tony.luck@...el.com, sathyanarayanan.kuppuswamy@...ux.intel.com,
	alpergun@...gle.com, jarkko@...nel.org, ashish.kalra@....com,
	nikunj.dadhania@....com, pankaj.gupta@....com,
	liam.merwick@...cle.com, zhi.a.wang@...el.com,
	Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH v10 07/50] x86/sev: Add RMP entry lookup helpers

On Mon, Dec 18, 2023 at 09:31:50PM -0600, Michael Roth wrote:
> I've moved this to sev.h, but it RMP_PG_SIZE_4K is already defined there
> and used by a bunch of guest code so it's a bit out-of-place to update
> those as part of this patchset. I can send a follow-up series to clean up
> some of the naming and get rid of sev-common.h

Yap, good idea.

> Doesn't seem like it would be an issue, maybe some fallout from any
> files that previously only included sev-common.h and now need to pull in
> guest struct definitions as well, but those definitions don't have a lot
> of external dependencies so don't anticipate any header include
> hellishness. I'll send that as a separate follow-up, along with some of
> the renames you suggested above since they'll touch guest code and
> create unecessary churn for SNP host support.

OTOH, people recently have started looking at including only that stuff
which is really used so having a single header would cause more
preprocessing effort. I'm not too crazy about it as the preprocessing
overhead is barely measurable so might as well have a single header and
then split it later...

Definitely something for the after-burner and not important right now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette