linux-kernel - Re: [PATCH] KVM: selftests: Delete superfluous, unused "stage" variable in AMX test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALMp9eQTtb9r+Jn5KnrTs1HDkFm0MWSJ5LxW2_3jrRE14TZtUA@mail.gmail.com>
Date: Tue, 9 Jan 2024 14:33:32 -0800
From: Jim Mattson <jmattson@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: Delete superfluous, unused "stage"
 variable in AMX test

On Tue, Jan 9, 2024 at 2:03 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> Delete the AMX's tests "stage" counter, as the counter is no longer used,
> which makes clang unhappy:
>
>   x86_64/amx_test.c:224:6: error: variable 'stage' set but not used
>           int stage, ret;
>               ^
>   1 error generated.
>
> Note, "stage" was never really used, it just happened to be dumped out by
> a (failed) assertion on run->exit_reason, i.e. the AMX test has no concept
> of stages, the code was likely copy+pasted from a different test.
>
> Fixes: c96f57b08012 ("KVM: selftests: Make vCPU exit reason test assertion common")
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Jim Mattson <jmattson@...gle.com>