linux-kernel - Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43a9b568-69b3-4f59-9f7b-c85880a55929@linux.ibm.com>
Date: Tue, 9 Jan 2024 17:55:08 -0600
From: Ninad Palsule <ninad@...ux.ibm.com>
To: Conor Dooley <conor@...nel.org>
Cc: Guenter Roeck <linux@...ck-us.net>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, joel@....id.au,
        andrew@...econstruct.com.au, peterhuewe@....de, jarkko@...nel.org,
        jgg@...pe.ca, keescook@...omium.org, tony.luck@...el.com,
        gpiccoli@...lia.com, johannes.holland@...ineon.com, broonie@...nel.org,
        patrick.rudolph@...ements.com, vincent@...emblay.dev,
        peteryin.openbmc@...il.com, lakshmiy@...ibm.com, bhelgaas@...gle.com,
        naresh.solanki@...ements.com, alexander.stein@...tq-group.com,
        festevam@...x.de, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-hardening@...r.kernel.org, geissonator@...oo.com
Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

Hi Conor,

On 1/9/24 11:14, Conor Dooley wrote:
> On Mon, Jan 08, 2024 at 02:05:53PM -0600, Ninad Palsule wrote:
>> Hello Guenter,
>>
>> On 12/12/23 13:50, Guenter Roeck wrote:
>>> On 12/12/23 10:51, Conor Dooley wrote:
>>>> On Tue, Dec 12, 2023 at 10:00:39AM -0800, Guenter Roeck wrote:
>>>>> On Tue, Dec 12, 2023 at 05:15:51PM +0000, Conor Dooley wrote:
>>>>>> On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote:
>>>>>>> From: Joel Stanley <joel@....id.au>
>>>>>>>
>>>>>>> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>>>>>>>
>>>>>>> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>>>>>>>
>>>>>>>
>>>>>>> Add a compatible string for it, and the generic compatible.
>>>>>>>
>>>>>>> OpenBMC-Staging-Count: 3
>>>>>> Delete this from every patch that it appears from.
>>
>> I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@linux.ibm.com/
> Why did you do that? It now just adds undocumented compatibles to the
> driver. Please, as Rob requested, work with Lukas on his series to make
> sure that these devices are documented.

I think krzysztof kozlowski suggested to send these patches separately: 
https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@linaro.org/

Did I misunderstood it? Do you guys want me to include that commit again?

Regards,

Ninad

>
> Thanks,
> Conor.