linux-kernel - RE: [tip: x86/boot] x86/boot: Ignore NMIs during very early boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 05:17:42 +0000
From: NOMURA JUNICHI(野村　淳一)
	<junichi.nomura@....com>
To: Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tip-commits@...r.kernel.org" <linux-tip-commits@...r.kernel.org>,
	Derek Barbosa <debarbos@...hat.com>, Kees Cook <keescook@...omium.org>, Linus
 Torvalds <torvalds@...ux-foundation.org>, "Paul E. McKenney"
	<paulmck@...nel.org>, Andy Lutomirski <luto@...nel.org>, "H. Peter Anvin"
	<hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, "x86@...nel.org"
	<x86@...nel.org>
Subject: RE: [tip: x86/boot] x86/boot: Ignore NMIs during very early boot

> From: Ingo Molnar <mingo.kernel.org@...il.com>
> * Borislav Petkov <bp@...en8.de> wrote:
> > On Thu, Nov 30, 2023 at 08:59:44AM -0000, tip-bot2 for Jun'ichi Nomura wrote:
> > > +void do_boot_nmi_trap(struct pt_regs *regs, unsigned long error_code)
> > > +{
> > > +	/* Empty handler to ignore NMI during early boot */
> >
> > It might be good to issue something here to say that a spurious NMI got
> > ignored.
> >
> > Something ala
> >
> > 	error_putstr("Spurious early NMI ignored.\n");
> >
> > so that we at least say that we ignored an NMI and not have it disappear
> > unnoticed.
> 
> That makes sense. Jun'ichi-san, could you please send a patch for this?

Thank you for comments.  I currently don't have an environment to send a
patch without white space damage.  Could it be possible for you to apply
the attached one?

--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

Download attachment "x86-early-nmi-add-msg.patch" of type "application/octet-stream" (851 bytes)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5779 bytes)