linux-kernel - Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3a7b43a-820e-4da7-96a6-633bd4f35f26@infradead.org>
Date: Mon, 8 Jan 2024 21:57:52 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Yishai Hadas <yishaih@...dia.com>,
 Alex Williamson <alex.williamson@...hat.com>, KVM list
 <kvm@...r.kernel.org>, virtualization@...ts.linux-foundation.org
Subject: Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)



On 1/7/24 21:09, Stephen Rothwell wrote:
> Hi all,
> 
> News: the merge window has opened, so please do not add any material
> intended for v6.9 to your linux-next included branches until asfter
> v6.8-rc1 has been released.
> 
> Changes since 20240105:
> 

on powerpc 64-bit:

when
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_PCI_ADMIN_LEGACY=y


powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_probe':
main.c:(.text+0x17c): undefined reference to `virtio_pci_admin_has_legacy_io'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_init_device':
main.c:(.text+0x82c): undefined reference to `virtio_pci_admin_legacy_io_notify_info'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_bar0_rw':
main.c:(.text+0xe98): undefined reference to `virtio_pci_admin_legacy_common_io_read'
powerpc64-linux-ld: main.c:(.text+0xecc): undefined reference to `virtio_pci_admin_legacy_device_io_read'
powerpc64-linux-ld: main.c:(.text+0x10d8): undefined reference to `virtio_pci_admin_legacy_common_io_write'
powerpc64-linux-ld: main.c:(.text+0x1108): undefined reference to `virtio_pci_admin_legacy_device_io_write'


Also, it is not a good idea to have a driver depend on a hidden (not visible) Kconfig symbol,
like this:

config VIRTIO_VFIO_PCI
        tristate "VFIO support for VIRTIO NET PCI devices"
        depends on VIRTIO_PCI_ADMIN_LEGACY


Full randconfig file is attached.

-- 
#Randy
Download attachment "config-r4841.gz" of type "application/gzip" (54792 bytes)