linux-kernel - Re: [PATCH] efi: Disable mirror feature during crashkernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZziDIc0C9BHhhu4@kernel.org>
Date: Tue, 9 Jan 2024 08:05:00 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Wupeng Ma <mawupeng1@...wei.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi: Disable mirror feature during crashkernel

On Tue, Jan 09, 2024 at 12:15:36PM +0800, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@...wei.com>
> 
> If system have no mirrored memory or use crashkernel.high while
> kernelcore=mirror is enabled in cmdline, during crashkernel,
> there will be limited mirrored memory and this usually lead to
> OOM.
> 
> To solve this problem, disable mirror feature during crashkernel.
> 
> Signed-off-by: Ma Wupeng <mawupeng1@...wei.com>

Acked-by: Mike Rapoport (IBM) <rppt@...nel.org>

> ---
>  mm/mm_init.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 077bfe393b5e..513bad672708 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -26,6 +26,7 @@
>  #include <linux/pgtable.h>
>  #include <linux/swap.h>
>  #include <linux/cma.h>
> +#include <linux/crash_dump.h>
>  #include "internal.h"
>  #include "slab.h"
>  #include "shuffle.h"
> @@ -381,6 +382,11 @@ static void __init find_zone_movable_pfns_for_nodes(void)
>  			goto out;
>  		}
>  
> +		if (is_kdump_kernel()) {
> +			pr_warn("The system is under kdump, ignore kernelcore=mirror.\n");
> +			goto out;
> +		}
> +
>  		for_each_mem_region(r) {
>  			if (memblock_is_mirror(r))
>  				continue;
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.