linux-kernel - Re: [PATCH v2] checkpatch: don't complain on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e117917b-6897-4209-82af-7757a93cf078@intel.com>
Date: Tue, 9 Jan 2024 08:32:05 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
	<linux-kernel@...r.kernel.org>
CC: Jacob Keller <jacob.e.keller@...el.com>, Dwaipayan Ray
	<dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, "Rasmus
 Villemoes" <rasmus.villemoes@...vas.dk>
Subject: Re: [PATCH v2] checkpatch: don't complain on _Generic() use

On 12/5/23 12:05, Przemek Kitszel wrote:
> Improve CamelCase recognition logic to avoid reporting on _Generic() use.
> 
> Other C keywords, such as _Bool, are intentionally omitted, as those
> should be rather avoided in new source code.
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> v2: _Static_assert dropped from the scope;
>      whole word match.
> 
> v1 link: https://lkml.org/lkml/2023/11/27/1055
> ---
>   scripts/checkpatch.pl | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 25fdb7fda112..1370f426949d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5839,6 +5839,8 @@ sub process {
>   #CamelCase
>   			if ($var !~ /^$Constant$/ &&
>   			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> +#Ignore C keywords
> +			    $var !~ /^_Generic$/ &&
>   #Ignore some autogenerated defines and enum values
>   			    $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
>   #Ignore Page<foo> variants
> 
> base-commit: 3706f141e5639d3034bd83448e929b8462362651

Hi,

could I do anything more to have this patch applied?

Przemek