linux-kernel - Re: [PATCH v5 1/1] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 09:02:38 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jingbao Qiu <qiujingbao.dlmu@...il.com>
Cc: a.zummo@...ertech.it, alexandre.belloni@...tlin.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/1] dt-bindings: rtc: sophgo: add RTC support for
 Sophgo CV1800 series SoC

On 09/01/2024 03:26, Jingbao Qiu wrote:
> On Mon, Jan 8, 2024 at 11:24 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 08/01/2024 14:47, Jingbao Qiu wrote:
>>>>> So I wrote the following in the changelog.
>>>>>
>>>>> - add syscon attribute to share registers
>>>>>   with POR
>>>>
>>>> Where is this syscon attribute? Please point me to specific line in DTS
>>>> and in the driver.
>>>
>>> I will explain in the next version of DTS.
>>> Thank you again for your patient reply.
>>
>> You added some syscon attribute. What is this?
>>
> 
> This RTC device has a POR submodule, which is explained in the description.
> The corresponding driver of the POR submodule provides power off
> restart function.
> The driver of the POR submodule just uses reg to work.As you mentioned in your
> last comment.POR  is empty, so there is little point in having it as
> subnode. we need
> share the reg to POR. RTC driver and POR driver will access this
> address simultaneously.
> so,I added this syscon attribute.

Nothing from above explains what is "syscon attribute", but if you
cannot explain it, at least point me to where did you add this syscon
attribute? Changelog said you added it. Where?

Best regards,
Krzysztof