linux-kernel - Re: [PATCH V4 net-next 1/4] net: hns3: add command queue trace for hns3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <866421af-16df-4911-8367-16523516b81e@huawei.com>
Date: Tue, 9 Jan 2024 16:19:22 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangjie125@...wei.com>, <liuyonglong@...wei.com>,
	<lanhao@...wei.com>, <wangpeiyang1@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 net-next 1/4] net: hns3: add command queue trace for
 hns3


on 2024/1/5 17:52, Jiri Pirko wrote:
> Fri, Jan 05, 2024 at 02:01:16AM CET, shaojijie@...wei.com wrote:
>> From: Hao Lan <lanhao@...wei.com>
>>
>> Currently, the hns3 driver does not have the trace
>> of the command queue. As a result, it is difficult to
>> locate the communication between the driver and firmware.
>> Therefore, the trace function of the command queue is
>> added in this test case to facilitate the locating of
>> communication problems between the driver and firmware.
> Use imperative mood in the patch desctiption so it is clear what is the
> intention of the patch:
> https://www.kernel.org/doc/html/v6.6/process/submitting-patches.html#describe-your-changes
>
Thanks, This patch desctiption will be rewritten in imperative mood in the next version.