Message-Id: <d9d3dbe5-1f5a-45cd-a5cc-a54836d8e077@app.fastmail.com>
Date: Tue, 09 Jan 2024 09:23:57 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "kernel test robot" <yujie.liu@...el.com>,
 "Linus Walleij" <linus.walleij@...aro.org>
Cc: "kernel test robot" <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 "Richard Henderson" <richard.henderson@...aro.org>,
 "Ivan Kokshaysky" <ink@...assic.park.msu.ru>,
 "Matt Turner" <mattst88@...il.com>
Subject: Re: arch/alpha/include/asm/core_t2.h:587:23: warning: no previous prototype
 for 't2_ioread64'

On Mon, Jan 8, 2024, at 10:56, Yujie Liu wrote:
> On Sun, Jan 07, 2024 at 09:09:21PM +0100, Linus Walleij wrote:
>> Hi robot,
>> 
>> On Sat, Jan 6, 2024 at 10:40 AM kernel test robot <lkp@...el.com> wrote:
>> 
>> 
>> > Hi Arnd,
>> >
>> > FYI, the error/warning still remains.
>> 
>> FYI I have already said I can't reproduce this at all. Not using
>> allnoconfig, not using the .config attached to the report.
>> 
>> I have no idea what this is.
>
> We double checked this, and looks like it needs to be reproduced by
> "make W=1". Could you please recheck with W=1?
>
> The following link has some hints of handling W=1 warnings:
>
> https://github.com/intel/lkp-tests/wiki/LKP-FAQ#how-is-one-meant-to-act-on-w1-reports-like--wmissing-prototypes
>
> Please kindly let us know if you'd like to ignore these W=1 warnings,
> and we will configure the bot for you to avoid further bothering.

This warning used to be part of the W=1 set (as well as C=1
with sparse) but is now enabled by default once my patch from
linux-mm makes it into mainline, but there are more things going
on here:

- the particular warning about t2_ioread64() gets flagged by lkp
  because it was introduced when I extended the ioread family
  to also include the 64-bit access rather than just 8/16/32 bit
  functions. The other ones were always there but are ignored
  by lkp.

- Someone who cares about alpha should just address all
  the warnings, including the old one about 'clone3' that needs
  to be done by someone that understands the alpha calling
  conventions, see below for the current output in linux-next.

- part of the problem of the missing-prototypes warnings on
  alpha is the extensive use of 'extern inline' on this
  architecture that should be replaced with 'static inline' in
  almost all cases (as we did on all other architectures
  decades ago).

    Arnd

8<---
<stdin>:1521:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/home/arnd/arm-soc/arch/alpha/kernel/traps.c:178:1: warning: no previous prototype for 'do_entArith' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/traps.c:200:1: warning: no previous prototype for 'do_entIF' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/traps.c:341:1: warning: no previous prototype for 'do_entDbg' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/traps.c:377:1: warning: no previous prototype for 'do_entUna' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/traps.c:662:1: warning: no previous prototype for 'do_entUnaUser' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/irq.c:96:1: warning: no previous prototype for 'handle_irq' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/irq_alpha.c:45:1: warning: no previous prototype for 'do_entInt' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/signal.c:205:1: warning: no previous prototype for 'do_sigreturn' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/signal.c:233:1: warning: no previous prototype for 'do_rt_sigreturn' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/signal.c:523:1: warning: no previous prototype for 'do_work_pending' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/ptrace.c:322:26: warning: no previous prototype for 'syscall_trace_enter' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/ptrace.c:334:1: warning: no previous prototype for 'syscall_trace_leave' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/io.c:654:1: warning: no previous prototype for 'scr_memcpyw' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/bugs.c:19:9: warning: no previous prototype for 'cpu_show_meltdown' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/bugs.c:28:9: warning: no previous prototype for 'cpu_show_spectre_v1' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/bugs.c:37:9: warning: no previous prototype for 'cpu_show_spectre_v2' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/pci.c:285:1: warning: no previous prototype for 'pcibios_claim_one_bus' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:457:20: warning: no previous prototype for 't2_readb' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:468:21: warning: no previous prototype for 't2_readw' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:483:21: warning: no previous prototype for 't2_readl' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:494:21: warning: no previous prototype for 't2_readq' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:507:22: warning: no previous prototype for 't2_writeb' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:518:22: warning: no previous prototype for 't2_writew' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:533:22: warning: no previous prototype for 't2_writel' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:542:22: warning: no previous prototype for 't2_writeq' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:554:31: warning: no previous prototype for 't2_ioportmap' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:559:31: warning: no previous prototype for 't2_ioremap' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:565:21: warning: no previous prototype for 't2_is_ioaddr' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:570:21: warning: no previous prototype for 't2_is_mmio' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:579:23: warning: no previous prototype for 't2_ioread8' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:586:22: warning: no previous prototype for 't2_iowrite8' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:579:23: warning: no previous prototype for 't2_ioread16' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:586:22: warning: no previous prototype for 't2_iowrite16' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:579:23: warning: no previous prototype for 't2_ioread32' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:586:22: warning: no previous prototype for 't2_iowrite32' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:579:23: warning: no previous prototype for 't2_ioread64' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:586:22: warning: no previous prototype for 't2_iowrite64' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/include/asm/core_t2.h:606:33: warning: no previous prototype for 't2_iounmap' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/srmcons.c:267:1: warning: no previous prototype for 'register_srm_console' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/srmcons.c:277:1: warning: no previous prototype for 'unregister_srm_console' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/console.c:39:1: warning: no previous prototype for 'locate_and_init_vga' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/console.c:72:1: warning: no previous prototype for 'find_console_vga_hose' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/core_cia.c:284:1: warning: no previous prototype for 'cia_pci_tbi_try2' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/core_cia.c:580:1: warning: no previous prototype for 'cia_save_srm_settings' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/core_cia.c:606:1: warning: no previous prototype for 'cia_restore_srm_settings' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/sys_nautilus.c:82:1: warning: no previous prototype for 'nautilus_kill_arch' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/sys_nautilus.c:131:1: warning: no previous prototype for 'nautilus_machine_check' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/sys_nautilus.c:201:1: warning: no previous prototype for 'nautilus_init_pci' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/smc37c669.c:2434:1: warning: no previous prototype for 'SMC37c669_dump_registers' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/smc37c669.c:2467:13: warning: no previous prototype for 'SMC669_Init' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/kernel/smc37c93x.c:238:12: warning: no previous prototype for 'SMC93x_Init' [-Wmissing-prototypes]
/home/arnd/arm-soc/arch/alpha/mm/init.c:261:1: warning: no previous prototype for 'srm_paging_stop' [-Wmissing-prototypes]

Powered by blists - more mailing lists