linux-kernel - Re: [PATCH v3 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALz278bzoQEUS+NMP=Xt9+4n4NovBR6bCucbvQp_FhHuMP0bnA@mail.gmail.com>
Date: Tue, 9 Jan 2024 17:00:17 +0800
From: Ban Feng <baneric926@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: jdelvare@...e.com, linux@...ck-us.net, krzysztof.kozlowski+dt@...aro.org, 
	conor+dt@...nel.org, corbet@....net, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, openbmc@...ts.ozlabs.org, kwliu@...oton.com, 
	kcfeng0@...oton.com, DELPHINE_CHIU@...ynn.com, Bonnie_Lo@...ynn.com, 
	naresh.solanki@...ements.com, billy_tsai@...eedtech.com
Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

On Thu, Jan 4, 2024 at 8:15 AM Rob Herring <robh@...nel.org> wrote:
>
> On Fri, Dec 22, 2023 at 09:33:50AM +0800, baneric926@...il.com wrote:
> > From: Naresh Solanki <naresh.solanki@...ements.com>
> >
> > Add common fan properties bindings to a schema.
> >
> > Bindings for fan controllers can reference the common schema for the
> > fan
> >
> > child nodes:
> >
> >   patternProperties:
> >     "^fan@[0-2]":
> >       type: object
> >       $ref: fan-common.yaml#
> >       unevaluatedProperties: false
> >
> > Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
> > Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
> > Signed-off-by: Ban Feng <kcfeng0@...oton.com>
> > ---
> >  .../devicetree/bindings/hwmon/fan-common.yaml | 76 +++++++++++++++++++
> >  1 file changed, 76 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> Please implement my comments on v10.
>

Hi Rob,

I saw Aspeed Billy has already added enum to below patch:
https://patchwork.kernel.org/project/linux-hwmon/patch/20240108074348.735014-2-billy_tsai@aspeedtech.com/

Thanks,
Ban