| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <688dc165-5fee-488f-bdf9-a855d2fac71d@broadcom.com>
Date: Mon, 8 Jan 2024 17:11:41 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Miklos Szeredi <mszeredi@...hat.com>, linux-fsdevel@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
linux-man@...r.kernel.org, linux-security-module@...r.kernel.org,
Karel Zak <kzak@...hat.com>, Ian Kent <raven@...maw.net>,
David Howells <dhowells@...hat.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Al Viro <viro@...iv.linux.org.uk>, Christian Brauner <christian@...uner.io>,
Amir Goldstein <amir73il@...il.com>, Matthew House
<mattlloydhouse@...il.com>, Florian Weimer <fweimer@...hat.com>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v4 6/6] wire up syscalls for statmount/listmount
Hello,
On 10/25/23 07:02, Miklos Szeredi wrote:
> Wire up all archs.
>
> Signed-off-by: Miklos Szeredi <mszeredi@...hat.com>
> ---
> arch/alpha/kernel/syscalls/syscall.tbl | 3 +++
> arch/arm/tools/syscall.tbl | 3 +++
> arch/arm64/include/asm/unistd32.h | 4 ++++
> arch/ia64/kernel/syscalls/syscall.tbl | 3 +++
> arch/m68k/kernel/syscalls/syscall.tbl | 3 +++
> arch/microblaze/kernel/syscalls/syscall.tbl | 3 +++
> arch/mips/kernel/syscalls/syscall_n32.tbl | 3 +++
> arch/mips/kernel/syscalls/syscall_n64.tbl | 3 +++
> arch/mips/kernel/syscalls/syscall_o32.tbl | 3 +++
> arch/parisc/kernel/syscalls/syscall.tbl | 3 +++
> arch/powerpc/kernel/syscalls/syscall.tbl | 3 +++
> arch/s390/kernel/syscalls/syscall.tbl | 3 +++
> arch/sh/kernel/syscalls/syscall.tbl | 3 +++
> arch/sparc/kernel/syscalls/syscall.tbl | 3 +++
> arch/x86/entry/syscalls/syscall_32.tbl | 3 +++
> arch/x86/entry/syscalls/syscall_64.tbl | 2 ++
> arch/xtensa/kernel/syscalls/syscall.tbl | 3 +++
> include/uapi/asm-generic/unistd.h | 8 +++++++-
> 18 files changed, 58 insertions(+), 1 deletion(-)
FWIW, this broke the compat build on ARM64:
/arch/arm64/include/asm/unistd32.h:922:24: error: array index in
initializer exceeds array bounds
922 | #define __NR_statmount 457
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
/arch/arm64/include/asm/unistd32.h:923:11: note: in expansion of macro
'__NR_statmount'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~~~~~~
/arch/arm64/include/asm/unistd32.h:922:24: note: (near initialization
for 'compat_sys_call_table')
922 | #define __NR_statmount 457
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
/arch/arm64/include/asm/unistd32.h:923:11: note: in expansion of macro
'__NR_statmount'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: warning: excess elements in array
initializer
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
/arch/arm64/include/asm/unistd32.h:923:1: note: in expansion of macro
'__SYSCALL'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: note: (near initialization for
'compat_sys_call_table')
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
/arch/arm64/include/asm/unistd32.h:923:1: note: in expansion of macro
'__SYSCALL'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~
/arch/arm64/include/asm/unistd32.h:924:24: error: array index in
initializer exceeds array bounds
924 | #define __NR_listmount 458
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
/arch/arm64/include/asm/unistd32.h:925:11: note: in expansion of macro
'__NR_listmount'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~~~~~~
/arch/arm64/include/asm/unistd32.h:924:24: note: (near initialization
for 'compat_sys_call_table')
924 | #define __NR_listmount 458
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
/arch/arm64/include/asm/unistd32.h:925:11: note: in expansion of macro
'__NR_listmount'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: warning: excess elements in array
initializer
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
/arch/arm64/include/asm/unistd32.h:925:1: note: in expansion of macro
'__SYSCALL'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: note: (near initialization for
'compat_sys_call_table')
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
/arch/arm64/include/asm/unistd32.h:925:1: note: in expansion of macro
'__SYSCALL'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~
host-make[5]: *** [scripts/Makefile.build:243:
arch/arm64/kernel/sys32.o] Error 1
host-make[4]: *** [scripts/Makefile.build:480: arch/arm64/kernel] Error 2
host-make[3]: *** [scripts/Makefile.build:480: arch/arm64] Error 2
host-make[3]: *** Waiting for unfinished jobs....
Sent out a fix for that:
https://lore.kernel.org/all/20240109010906.429652-1-florian.fainelli@broadcom.com/
--
Florian
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)
Powered by blists - more mailing lists