linux-kernel - Re: [PATCH for-next v4 2/2] RDMA/rxe: Remove rxe_info from rxe_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEz=LcvphS6QECpHTFhrRoC=FcSbEU4j_XuqJF7ognjJu+uF6Q@mail.gmail.com>
Date: Tue, 9 Jan 2024 17:20:00 +0800
From: Greg Sword <gregsword0@...il.com>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: linux-rdma@...r.kernel.org, zyjzyj2000@...il.com, jgg@...pe.ca, 
	leon@...nel.org, linux-kernel@...r.kernel.org, rpearsonhpe@...il.com
Subject: Re: [PATCH for-next v4 2/2] RDMA/rxe: Remove rxe_info from rxe_set_mtu

On Tue, Jan 9, 2024 at 4:41 PM Li Zhijian <lizhijian@...itsu.com> wrote:
>
> commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log messages to err and info")
> newly added this info. But it did only show null device when
> the rdma_rxe is being loaded because dev_name(rxe->ib_dev->dev)
> has not yet been assigned at the moment:
>
> "(null): rxe_set_mtu: Set mtu to 1024"
>
> Remove it to silent this message, check the mtu from it backend link
> instead if needed.
>
> CC: Bob Pearson <rpearsonhpe@...il.com>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
> V4: Remove it rather than re-order rxe_set_mtu() and rxe_register_device()
> ---
>  drivers/infiniband/sw/rxe/rxe.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index a086d588e159..ae466e72fc43 100644
> --- a/drivers/infiniband/sw/rxe/rxe.c
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -160,8 +160,6 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu)
>
>         port->attr.active_mtu = mtu;
>         port->mtu_cap = ib_mtu_enum_to_int(mtu);
> -
> -       rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);

I'd like to keep this statement so I can tell if the mtu setup was
successful or not.

>  }
>
>  /* called by ifc layer to create new rxe device.
> --
> 2.29.2
>
>