linux-kernel - Re: [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 10:24:27 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Zhi Mao <zhi.mao@...iatek.com>, mchehab@...nel.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, sakari.ailus@...ux.intel.com
Cc: laurent.pinchart@...asonboard.com, shengnan.wang@...iatek.com,
 yaya.chang@...iatek.com, 10572168@...com,
 Project_Global_Chrome_Upstream_Group@...iatek.com, yunkec@...omium.org,
 conor+dt@...nel.org, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, jacopo.mondi@...asonboard.com,
 hverkuil-cisco@...all.nl, heiko@...ech.de, jernej.skrabec@...il.com,
 macromorgan@...mail.com, linus.walleij@...aro.org, hdegoede@...hat.com,
 tomi.valkeinen@...asonboard.com, gerald.loacker@...fvision.net,
 andy.shevchenko@...il.com, bingbu.cao@...el.com,
 dan.scally@...asonboard.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3
 bindings

On 09/01/2024 03:27, Zhi Mao wrote:
> Add YAML device tree binding for GC08A3 CMOS image sensor,
> and the relevant MAINTAINERS entries.
> 

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Subject: only one "media", so:
media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor

> Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>

..

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor0@31 {

sensor@31

With above fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Before you reply, fix your email client. It's impossible to read your
responses.

Best regards,
Krzysztof