linux-kernel - Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1d20997-d09b-464c-8d23-0b7a15972a2b@linaro.org>
Date: Tue, 9 Jan 2024 10:32:18 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elad Nachman <enachman@...vell.com>, Conor Dooley <conor@...nel.org>
Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5

On 08/01/2024 19:15, Elad Nachman wrote:
> 
> 
>> -----Original Message-----
>> From: Conor Dooley <conor@...nel.org>
>> Sent: Monday, January 8, 2024 8:01 PM
>> To: Elad Nachman <enachman@...vell.com>
>> Cc: gregkh@...uxfoundation.org; robh+dt@...nel.org;
>> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>> devicetree@...r.kernel.org; linux-usb@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
>>
>> On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Conor Dooley <conor@...nel.org>
>>>> Sent: Monday, January 8, 2024 7:15 PM
>>>> To: Elad Nachman <enachman@...vell.com>
>>>> Cc: gregkh@...uxfoundation.org; robh+dt@...nel.org;
>>>> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>>>> devicetree@...r.kernel.org; linux-usb@...r.kernel.org; linux-
>>>> kernel@...r.kernel.org
>>>> Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
>>>>
>>>> External Email
>>>>
>>>> --------------------------------------------------------------------
>>>> -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
>>>>> From: Elad Nachman <enachman@...vell.com>
>>>>>
>>>>> Add Marvell ac5 device tree bindings to generic EHCI.
>>>>> This compatible enables the Marvell Orion platform code to
>>>>> properly configure the DMA mask for the Marvell AC5 SOC.
>>>>>
>>>>> Signed-off-by: Elad Nachman <enachman@...vell.com>
>>>>
>>>> Maybe I am dumb, but I don't understand how this does what the
>>>> commit message says. There's no fallback to generic-ehci or any
>>>> other compatible that is already understood by the driver.
>>>>
>>>> What am I missing?
>>>
>>> Following guidance by Andrew Lunn on my mmc patchset, I have split the
>>> patchset Into a single patch for dt-bindings review and another for USB
>> driver review.
>>
>> I don't understand that advice. dt-bindings should (almost) always be with
>> the driver. Otherwise you just confuse people like me.
>>
>> Perhaps Andrew meant sending dt*s* patches separately from the driver &
>> bindings?
> 
> The rational was different people making the actual merge, into different intermediate git REPOs, before mering into linux-next.

Sorry, but NAK. The submitting-patches for bindings expresses this as
well: bindings go with the driver.

There was never an advice from Andrew about splitting binding. He
clearly said that FIRST PATCH, so the DTS, goes via separate tree.
Absolutely nothing about splitting the binding.

https://lore.kernel.org/all/cfbbe706-5953-488c-9bff-f72f6d00b44f@lunn.ch/


Best regards,
Krzysztof