[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <8f50f1b2-68b0-46bd-9bf8-3ddbbaee249d@app.fastmail.com>
Date: Tue, 09 Jan 2024 11:38:51 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Chen-Yu Tsai" <wenst@...omium.org>
Cc: "Kalle Valo" <kvalo@...nel.org>,
"Jeff Johnson" <quic_jjohnson@...cinc.com>,
"Bartosz Golaszewski" <brgl@...ev.pl>,
"David S . Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>, "Rob Herring" <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
"Conor Dooley" <conor+dt@...nel.org>,
"Bjorn Andersson" <andersson@...nel.org>,
"Konrad Dybcio" <konrad.dybcio@...aro.org>,
"Catalin Marinas" <catalin.marinas@....com>,
"Will Deacon" <will@...nel.org>, "Bjorn Helgaas" <bhelgaas@...gle.com>,
Heiko Stübner <heiko@...ech.de>,
"Jernej Skrabec" <jernej.skrabec@...il.com>,
"Chris Morgan" <macromorgan@...mail.com>,
"Linus Walleij" <linus.walleij@...aro.org>,
"Geert Uytterhoeven" <geert+renesas@...der.be>,
"Neil Armstrong" <neil.armstrong@...aro.org>,
Nícolas F. R. A. Prado <nfraprado@...labora.com>,
"Marek Szyprowski" <m.szyprowski@...sung.com>,
"Peng Fan" <peng.fan@....com>, "Robert Richter" <rrichter@....com>,
"Dan Williams" <dan.j.williams@...el.com>,
"Jonathan Cameron" <Jonathan.Cameron@...wei.com>,
"Terry Bowman" <terry.bowman@....com>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@...ux.intel.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
"Huacai Chen" <chenhuacai@...nel.org>, "Alex Elder" <elder@...aro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@...aro.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-pci@...r.kernel.org,
"Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>
Subject: Re: [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390
On Tue, Jan 9, 2024, at 11:26, Chen-Yu Tsai wrote:
> On Tue, Jan 9, 2024 at 6:15 PM Arnd Bergmann <arnd@...db.de> wrote:
>> On Tue, Jan 9, 2024, at 11:09, Kalle Valo wrote:
>> > Chen-Yu Tsai <wenst@...omium.org> writes:
>> >> On Tue, Jan 9, 2024 at 5:18 PM Kalle Valo <kvalo@...nel.org> wrote:
>> If this is indeed what you want, it's still better to do the
>> equivalent expression in PCIE_PWRSEQ_QCA6390 rather than ATH11K:
>>
>> config PCIE_PWRSEQ_QCA6390
>> tristate "PCIe Power Sequencing driver for QCA6390"
>> default ATH11K && ARCH_QCOM
>
> PCIE_PWRSEQ_QCA6390 is also guarded by PCIE_PWRSEQ though. That would
> require the default statement to be duplicated to the PCIE_PWRSEQ option
> as well.
>
> Presumably we'd get a few more power sequencing drivers, and the list of
> default statements for PCIE_PWRSEQ would grow.
>
> If that's acceptable then Arnd's proposal plus duplicating it to
> PCIE_PWRSEQ should work as described.
Does PCIE_PWRSEQ need to be user-visible? If this is a hidden symbol
that gets selected by PCIE_PWRSEQ_QCA6390 and any future ones, it
would still get enabled.
Another possibility would be to have PCIE_PWRSEQ be default-enabled,
but allow it to be turned off in order to hide the other options
when users are sure they don't need it (e.g. when building a
specialized kernel for a particular board).
Arnd
Powered by blists - more mailing lists