[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1571880.1704798511@warthog.procyon.org.uk>
Date: Tue, 09 Jan 2024 11:08:31 +0000
From: David Howells <dhowells@...hat.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: dhowells@...hat.com, Lukas Bulwahn <lukas.bulwahn@...il.com>,
linux-cachefs@...hat.com,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Reference to non-existing CONFIG_NETFS_FSCACHE
Matthew Wilcox <willy@...radead.org> wrote:
> > netfs_writepages_begin() has the wait on the fscache folio conditional on
> > CONFIG_NETFS_FSCACHE - which doesn't exist.
> >
> > Fix it to be conditional on CONFIG_FSCACHE instead.
>
> Why is it conditional at all? Why don't we have a stub function if
> CONFIG_FSCACHE is not defined?
At this point, I'd rather just change the #ifdef and then (hopefully) next
cycle get rid of PG_fscache entirely, rendering this unnecessary.
David
Powered by blists - more mailing lists