linux-kernel - Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99d7bb85-17b0-4b5e-a6cf-f5957ad92298@linaro.org>
Date: Tue, 9 Jan 2024 12:19:03 +0100
From: neil.armstrong@...aro.org
To: Shengyang Chen <shengyang.chen@...rfivetech.com>,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc: quic_jesszhan@...cinc.com, sam@...nborg.org, airlied@...il.com,
 daniel@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, wahrenst@....net, dave.stevenson@...pberrypi.com,
 thierry.reding@...il.com, changhuang.liang@...rfivetech.com,
 keith.zhao@...rfivetech.com, jack.zhu@...rfivetech.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

Hi,

On 09/01/2024 08:09, Shengyang Chen wrote:
> This patchset adds waveshare 7inch touchscreen panel support
> for the StarFive JH7110 SoC.

Could you precise which SKU you're referring to ? is it 19885 => https://www.waveshare.com/7inch-dsi-lcd.htm ?

Are you sure it requires different timings from the RPi one ? In the Waveshare
wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD

Neil

> 
> 
> changes since v1:
> - Rebased on tag v6.7.
> 
> patch 1:
> - Gave up original changing.
> - Changed the commit message.
> - Add compatible in panel-simple.yaml
> 
> patch 2:
> - Gave up original changing.
> - Changed the commit message.
> - Add new mode for the panel in panel-simple.c
> 
> v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
> 
> Shengyang Chen (2):
>    dt-bindings: display: panel: panel-simple: Add compatible property for
>      waveshare 7inch touchscreen panel
>    gpu: drm: panel: panel-simple: add new display mode for waveshare
>      7inch touchscreen panel
> 
>   .../bindings/display/panel/panel-simple.yaml  |  2 ++
>   drivers/gpu/drm/panel/panel-simple.c          | 28 +++++++++++++++++++
>   2 files changed, 30 insertions(+)
>