linux-kernel - Re: [PATCH 1/5] staging: rtl8192e: rename variable is40MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <871qarcmzt.fsf@fastmail.org>
Date: Mon, 08 Jan 2024 20:25:55 -0500
From: Gary Rookard <garyrookard@...tmail.org>
To: Gary Rookard <garyrookard@...tmail.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, gregkh@...uxfoundation.org,
 philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable is40MHz


Gary Rookard <garyrookard@...tmail.org> writes:

> Gary Rookard <garyrookard@...tmail.org> writes:
>
>> [[PGP Signed Part:Undecided]]
>>
>> Dan Carpenter <dan.carpenter@...aro.org> writes:
>>
>>> On Sun, Jan 07, 2024 at 10:22:29PM -0500, Gary Rookard wrote:
>>>> Coding style issue, checkpatch avoid CamelCase,
>>>> rename it. is40MHz -> is_40mhz
>>>> 
>>>> Signed-off-by: Gary Rookard <garyrookard@...tmail.org>
>>>> ---
>>>>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
>>>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>>> 
>>>> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>>>> index 6d0912f90198..1b1cb9514028 100644
>>>> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
>>>> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>>>> @@ -87,36 +87,36 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
>>>>  {
>>>>  	struct rt_hi_throughput *ht_info = ieee->ht_info;
>>>>  
>>>> -	u8	is40MHz = (ht_info->cur_bw_40mhz) ? 1 : 0;
>>>> +	u8	is_40mhz = (ht_info->cur_bw_40mhz) ? 1 : 0;
>>>
>>> This should be is_40MHz.  It's metric.  M means Mega.  m means milli.
>>>
>>> regards,
>>> dan carpenter
>> --
>> Okay, stupid me didin't give it to much thought that way,
>> ...wow there's more that way then just mine
>> Good catch!
>> Regards,
>> Gary
--
There's only mine that I can find, I'll fix them up
and resubmit them.

Thanks for your insight.

Regards,
Gary
-- 
Sent with my mu4e on Void GNU/Linux.

Download attachment "signature.asc" of type "application/pgp-signature" (870 bytes)