linux-kernel - Re: [PATCH v3 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtCZVCB1yoocEUjLweodqkLVsF-+WwJzYruD17b0YKxS5A@mail.gmail.com>
Date: Tue, 9 Jan 2024 14:33:00 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Dietmar Eggemann <dietmar.eggemann@....com>
Cc: linux@...linux.org.uk, catalin.marinas@....com, will@...nel.org, 
	sudeep.holla@....com, rafael@...nel.org, viresh.kumar@...aro.org, 
	agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org, 
	mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com, 
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, 
	vschneid@...hat.com, lukasz.luba@....com, rui.zhang@...el.com, 
	mhiramat@...nel.org, daniel.lezcano@...aro.org, amit.kachhap@...il.com, 
	corbet@....net, gregkh@...uxfoundation.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	qyousef@...alina.io
Subject: Re: [PATCH v3 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure

On Tue, 9 Jan 2024 at 12:56, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
>
> On 08/01/2024 14:48, Vincent Guittot wrote:
> > Now that cpufreq provides a pressure value to the scheduler, rename
>
> I.e. that thermal (e.g. IPA governor) switches from average
> (rq->avg_(thermal/hw).load_avg) (1) to instantenous (cpu_pressure) (2).
> I rememeber a related dicussion during LPC 2018 :-)
>
> > arch_update_thermal_pressure into HW pressure to reflect that it returns
> > a pressure applied by HW (i.e. with a high frequency change) and not
> > always related to thermal mitigation but also generated by max current
> > limitation as an example. Such high frequency signal needs filtering to be
> > smoothed and provide an value that reflects the average available capacity
> > into the scheduler time scale.
>
> So 'drivers/cpufreq/qcom-cpufreq-hw.c' is the only user of (1) right
> now. Are we expecting more users here? If this stays the only user,
> maybe it can do the averages by itself and we can completely switch to (2)?

Yes I expect more users for this high frequency change which is
typically 1ms and below. And I prefer to keep PELT averaging
calculation inside scheduler instead of letting driver doing their own
averaging which will be most of the time not aligned with what
scheduler wants

>
> [...]
>