linux-kernel - Re: [PATCH] iio: core: use INDIO_ALL_BUFFER_MODES in iio_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d927b0b761eb7105d2193d9dca48f2c6df8868b7.camel@gmail.com>
Date: Tue, 09 Jan 2024 15:07:57 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Jonathan Cameron
 <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: core: use INDIO_ALL_BUFFER_MODES in
 iio_buffer_enabled()

On Mon, 2024-01-08 at 14:06 -0600, David Lechner wrote:
> This replaces use of individual buffer mode flags with
> INDIO_ALL_BUFFER_MODES in the iio_buffer_enabled() function.
> 
> This simplifies the code and makes it robust in case of the addition of
> new buffer modes.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---

LGTM,
Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/industrialio-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index c77745b594bd..8855d377d710 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -210,9 +210,7 @@ bool iio_buffer_enabled(struct iio_dev *indio_dev)
>  {
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
>  
> -	return iio_dev_opaque->currentmode &
> -	       (INDIO_BUFFER_HARDWARE | INDIO_BUFFER_SOFTWARE |
> -		INDIO_BUFFER_TRIGGERED);
> +	return iio_dev_opaque->currentmode & INDIO_ALL_BUFFER_MODES;
>  }
>  EXPORT_SYMBOL_GPL(iio_buffer_enabled);
>