linux-kernel - Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0izfETgX_652rk9q83JyP4Tne5H7CaH3DGqr5+xHMttKA@mail.gmail.com>
Date: Tue, 9 Jan 2024 15:23:03 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Michael Maltsev <mekosko@...jectyo.network>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CGA

On Sun, Jan 7, 2024 at 9:59 AM Michael Maltsev
<mekosko@...jectyo.network> wrote:
>
> Like the ASUS ExpertBook B1502CBA and various ASUS laptops, the
> ASUS ExpertBook B1502CGA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
>
>         $ sudo dmesg | grep DMI
>         [    0.000000] DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CGA_B1502CGA/B1502CGA, BIOS B1502CGA.303 06/05/2023
>         $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
>                         IRQ (Level, ActiveLow, Exclusive, )
>                             {1}
>
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
>
> Signed-off-by: Michael Maltsev <mekosko@...jectyo.network>
> ---
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index c297e40c5bdc..b0c3da70f809 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -453,6 +453,13 @@ static const struct dmi_system_id asus_laptop[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "B1402CVA"),
>                 },
>         },
> +       {
> +               .ident = "Asus ExpertBook B1502CGA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "B1502CGA"),
> +               },
> +       },
>         {
>                 .ident = "Asus ExpertBook B2402CBA",
>                 .matches = {
> --

Applied as 6.8-rc1 material, but I've replaced the unnecessary .ident
field with a comment.

Thanks!