linux-kernel - Re: [PATCH net-next 01/10] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZ1YSDBBUYR/Zn2j@gmail.com>
Date: Tue, 9 Jan 2024 06:29:28 -0800
From: Breno Leitao <leitao@...ian.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	Greg Ungerer <gerg@...ux-m68k.org>,
	Bagas Sanjaya <bagasdotme@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 01/10] net: fill in MODULE_DESCRIPTION()s for
 8390

On Tue, Jan 09, 2024 at 12:25:14PM +0100, Geert Uytterhoeven wrote:
> Hi Breno,
> 
> On Mon, Jan 8, 2024 at 7:17 PM Breno Leitao <leitao@...ian.org> wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to all the good old 8390 modules and drivers.
> >
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> 
> Thanks for your patch!
> 
> > --- a/drivers/net/ethernet/8390/apne.c
> > +++ b/drivers/net/ethernet/8390/apne.c
> > @@ -610,4 +610,5 @@ static int init_pcmcia(void)
> >         return 1;
> >  }
> >
> > +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver");
>
> I would write:
> 
>     National Semiconductor 8390 Amiga PCMCIA ethernet driver
> 
> as this driver does not work on generic platforms with a PCMCIA slot.

Thanks. I will update and send a v2.