linux-kernel - Re: [PATCH] arm64: irq: include <linux/cpumask.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZZ1cRnjNlryrqAL0@FVFF77S0Q05N.cambridge.arm.com>
Date: Tue, 9 Jan 2024 14:46:30 +0000
From: Mark Rutland <mark.rutland@....com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: catalin.marinas@....com, will@...nel.org, sumit.garg@...aro.org,
	dianders@...omium.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com,
	andre.draszik@...aro.org, willmcvicker@...gle.com,
	peter.griffin@...aro.org
Subject: Re: [PATCH] arm64: irq: include <linux/cpumask.h>

On Tue, Jan 09, 2024 at 02:04:37PM +0000, Tudor Ambarus wrote:
> Sorting include files in alphabetic order in
> drivers/tty/serial/samsung.c revealed the following error:
> 
> In file included from drivers/tty/serial/samsung_tty.c:24:
> ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name 'cpumask_t'
>     9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu);
>       |                                           ^~~~~~~~~
> 
> Include cpumask.h to avod unknown type errors for parents of irq.h that
> don't include cpumask.h.

s/avod/avoid/

> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  arch/arm64/include/asm/irq.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
> index 50ce8b697ff3..d5612bc770da 100644
> --- a/arch/arm64/include/asm/irq.h
> +++ b/arch/arm64/include/asm/irq.h
> @@ -5,6 +5,7 @@
>  #ifndef __ASSEMBLER__
>  
>  #include <asm-generic/irq.h>
> +#include <linux/cpumask.h>

Minor nit: we usually have the <linux/*.h> headers first, then a line space,
then the <asm/*.h> headers, e.g.

| #include <linux/cpumask.h>
| 
| #include <asm-generic/irq.h>

With those changes, the patch itself looks good to me:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

>  void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu);
>  #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
> -- 
> 2.43.0.472.g3155946c3a-goog
>