[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea02d7ca-62e2-4d46-8495-ed6e515625a1@linaro.org>
Date: Tue, 9 Jan 2024 16:01:19 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>
Cc: peter.griffin@...aro.org, krzysztof.kozlowski+dt@...aro.org,
mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
andi.shyti@...nel.org, alim.akhtar@...sung.com, gregkh@...uxfoundation.org,
jirislaby@...nel.org, s.nawrocki@...sung.com, tomasz.figa@...il.com,
cw00.choi@...sung.com, arnd@...db.de, semen.protsenko@...aro.org,
andre.draszik@...aro.org, saravanak@...gle.com, willmcvicker@...gle.com,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-serial@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add
PERIC0 clock management unit
On 09/01/2024 12:58, Tudor Ambarus wrote:
>
>
> On 1/9/24 11:09, Krzysztof Kozlowski wrote:
>> On 09/01/2024 05:03, Rob Herring wrote:
>>> On Thu, Dec 28, 2023 at 12:57:54PM +0000, Tudor Ambarus wrote:
>>>> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0)
>>>> clock management unit.
>>>>
>>>> Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>
>>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
>>>> ---
>>>> v2:
>>>> - fix comments as per Sam's suggestion and collect his R-b tag
>>>> - Rob's suggestion of renaming the clock-names to just "bus" and "ip"
>>>> was not implemented as I felt it affects readability in the driver
>>>> and consistency with other exynos clock drivers. I will happily update
>>>> the names in the -rc phase if someone else has a stronger opinion than
>>>> mine.
>>>
>>> I'll defer to Krzysztof.
>>
>> I miss the point why clock-names cannot be fixed now. This is the name
>> of property, not the input clock name.
>
> They can be fixed now. I've just aired the fixes at:
> https://lore.kernel.org/linux-arm-kernel/20240109114908.3623645-1-tudor.ambarus@linaro.org/
>
> Preparing v3 for this patch set to include the updated names here too.
I think I was not that clear enough. I did not get your current patchset
- so PERIC0 clock controller - cannot use new naming.
Best regards,
Krzysztof
Powered by blists - more mailing lists