linux-kernel - Re: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30948df0bebe6d37d722b4ca4ab5feba7b7c0895.camel@linux.intel.com>
Date: Tue, 09 Jan 2024 10:25:21 -0600
From: Tom Zanussi <tom.zanussi@...ux.intel.com>
To: Minjie Du <duminjie@...o.com>, Herbert Xu <herbert@...dor.apana.org.au>,
  "David S. Miller" <davem@...emloft.net>, "open list:INTEL IAA CRYPTO
 DRIVER" <linux-crypto@...r.kernel.org>, open list
 <linux-kernel@...r.kernel.org>
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] crypto: iaa - Remove unnecessary
 debugfs_create_dir() error check in iaa_crypto_debugfs_init()

On Tue, 2024-01-09 at 10:19 +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is
> developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>

Acked-by: Tom Zanussi <tom.zanussi@...ux.intel.com>

Thanks Minjie,

Tom

> ---
>  drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> index 2e3b7b73af20..cbf87d0effe3 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
>                 return -ENODEV;
>  
>         iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto",
> NULL);
> -       if (!iaa_crypto_debugfs_root)
> -               return -ENOMEM;
>  
>         debugfs_create_u64("max_comp_delay_ns", 0644,
>                            iaa_crypto_debugfs_root,
> &max_comp_delay_ns);