linux-kernel - Re: [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y1cycv9h.fsf@kernel.org>
Date: Tue, 09 Jan 2024 18:43:38 +0200
From: Kalle Valo <kvalo@...nel.org>
To: "Arnd Bergmann" <arnd@...db.de>
Cc: "Chen-Yu Tsai" <wenst@...omium.org>,  "Jeff Johnson"
 <quic_jjohnson@...cinc.com>,  "Bartosz Golaszewski" <brgl@...ev.pl>,
  "David S . Miller" <davem@...emloft.net>,  "Eric Dumazet"
 <edumazet@...gle.com>,  "Jakub Kicinski" <kuba@...nel.org>,  "Paolo Abeni"
 <pabeni@...hat.com>,  "Rob Herring" <robh+dt@...nel.org>,  "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,  "Conor Dooley"
 <conor+dt@...nel.org>,  "Bjorn Andersson" <andersson@...nel.org>,  "Konrad
 Dybcio" <konrad.dybcio@...aro.org>,  "Catalin Marinas"
 <catalin.marinas@....com>,  "Will Deacon" <will@...nel.org>,  "Bjorn
 Helgaas" <bhelgaas@...gle.com>,  Heiko Stübner
 <heiko@...ech.de>,  "Jernej
 Skrabec" <jernej.skrabec@...il.com>,  "Chris Morgan"
 <macromorgan@...mail.com>,  "Linus Walleij" <linus.walleij@...aro.org>,
  "Geert Uytterhoeven" <geert+renesas@...der.be>,  "Neil Armstrong"
 <neil.armstrong@...aro.org>,  Nícolas F. R. A. Prado
 <nfraprado@...labora.com>,  "Marek Szyprowski" <m.szyprowski@...sung.com>,
  "Peng Fan" <peng.fan@....com>,  "Robert Richter" <rrichter@....com>,
  "Dan Williams" <dan.j.williams@...el.com>,  "Jonathan Cameron"
 <Jonathan.Cameron@...wei.com>,  "Terry Bowman" <terry.bowman@....com>,
  "Kuppuswamy Sathyanarayanan"
 <sathyanarayanan.kuppuswamy@...ux.intel.com>,  Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>,  "Huacai Chen" <chenhuacai@...nel.org>,
  "Alex Elder" <elder@...aro.org>,  "Srinivas Kandagatla"
 <srinivas.kandagatla@...aro.org>,  "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>,  linux-wireless@...r.kernel.org,  Netdev
 <netdev@...r.kernel.org>,  devicetree@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-arm-msm@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,  linux-pci@...r.kernel.org,
  "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>
Subject: Re: [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390

"Arnd Bergmann" <arnd@...db.de> writes:

> On Tue, Jan 9, 2024, at 11:09, Kalle Valo wrote:
>
>> Chen-Yu Tsai <wenst@...omium.org> writes:
>>> On Tue, Jan 9, 2024 at 5:18 PM Kalle Valo <kvalo@...nel.org> wrote:
>>>> Jeff Johnson <quic_jjohnson@...cinc.com> writes:
>>>>
>>>> > On 1/4/2024 5:01 AM, Bartosz Golaszewski wrote:
>>>> >> diff --git a/drivers/pci/pcie/pwrseq/Kconfig b/drivers/pci/pcie/pwrseq/Kconfig
>>>> >> index 010e31f432c9..f9fe555b8506 100644
>>>> >> --- a/drivers/pci/pcie/pwrseq/Kconfig
>>>> >> +++ b/drivers/pci/pcie/pwrseq/Kconfig
>>>> >> @@ -6,3 +6,14 @@ menuconfig PCIE_PWRSEQ
>>>> >>      help
>>>> >>        Say yes here to enable support for PCIe power sequencing
>>>> >>        drivers.
>>>> >> +
>>>> >> +if PCIE_PWRSEQ
>>>> >> +
>>>> >> +config PCIE_PWRSEQ_QCA6390
>>>> >> +    tristate "PCIe Power Sequencing driver for QCA6390"
>>>> >> +    depends on ARCH_QCOM || COMPILE_TEST
>>>> >> +    help
>>>> >> +      Enable support for the PCIe power sequencing driver for the
>>>> >> +      ath11k module of the QCA6390 WLAN/BT chip.
>>>> >> +
>>>> >> +endif
>>>> >
>>>> > As I mentioned in the 5/9 patch I'm concerned that the current
>>>> > definition of PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390 will effectively hide
>>>> > the fact that QCA6390 may need additional configuration since the menu
>>>> > item will only show up if you have already enabled PCIE_PWRSEQ.
>>>> > Yes I see that these are set in the defconfig in 9/9 but I'm concerned
>>>> > about the more generic case.
>>>> >
>>>> > I'm wondering if there should be a separate config QCA6390 within ath11k
>>>> > which would then select PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390
>>>>
>>>> Or is it possible to provide an optional dependency in Kconfig (I guess
>>>
>>> imply PCIE_PWRSEQ
>>> imply PCIE_PWRSEQ_QCA6390
>>> ?
>>
>> Nice, I had forgotten imply altogether. Would 'imply
>> PCIE_PWRSEQ_QCA6390' in ath11k Kconfig be enough to address Jeff's
>> concern?
>
> Please don't use imply (ever), it doesn't normally do
> what you want. In this case, the only effect the
> 'imply' has is to change the default of the PCIE_PWRSEQ_QCA6390
> option when a defconfig contains QCA6390.
>
> If this is indeed what you want, it's still better to do the
> equivalent expression in PCIE_PWRSEQ_QCA6390 rather than ATH11K:
>
> config PCIE_PWRSEQ_QCA6390
>       tristate "PCIe Power Sequencing driver for QCA6390"
>       default ATH11K && ARCH_QCOM

Sounds good to me but should it be 'default ATH11K_PCI && ARCH_QCOM'? My
understanding is that we don't need PWRSEQ for ATH11K_AHB devices.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches