linux-kernel - Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 13:05:21 -0500
From: Jim Quinlan <jim2101024@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Cyril Brulebois <kibi@...ian.org>, 
	Jim Quinlan <james.quinlan@...adcom.com>, linux-pci@...r.kernel.org, 
	Nicolas Saenz Julienne <nsaenz@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Phil Elwell <phil@...pberrypi.com>, 
	bcm-kernel-feedback-list@...adcom.com, Conor Dooley <conor+dt@...nel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Krzysztof Wilczyński <kw@...ux.com>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, 
	open list <linux-kernel@...r.kernel.org>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@...ts.infradead.org>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

On Wed, Dec 13, 2023 at 2:59 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Tue, Dec 12, 2023 at 03:51:12PM -0800, Florian Fainelli wrote:
> > On 11/26/23 12:19, Cyril Brulebois wrote:
> > > Hi Jim,
> > >
> > > Jim Quinlan <james.quinlan@...adcom.com> (2023-11-13):
> > > > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> > > >     -- Squashed last two commits of v7 (Bjorn)
> > > >     -- Fix DT binding description text wrapping (Bjorn)
> > > >     -- Fix incorrect Spec reference (Bjorn)
> > > >           s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> > > >     -- Text substitutions (Bjorn)
> > > >           s/WRT/With respect to/
> > > >           s/Tclron/T_CLRon/
> > > >
> > > > v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
> > > >        network phy-mode and (b) keeping the code simple (not counting clkreq
> > > >        signal appearances, un-advertising capabilites, etc).  This is
> > > >        what I have done.  The property is now "brcm,clkreq-mode" and
> > > >        the values may be one of "safe", "default", and "no-l1ss".  The
> > > >        default setting is to employ the most capable power savings mode.
> > >
> > > Still:
> > >
> > > Tested-by: Cyril Brulebois <cyril@...amax.com>
> >
> > Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
>
> Seems OK to me if Lorenzo or Krzysztof W. are OK with it.
>
Bjorn,

What is the status of this submission?  Stock Linux on RPi4 CM4
systems with a PCIe device  panic on boot until this commit is
applied.

Regards,
Jim Quinilan
Broadcom STB/CM