linux-kernel - RE: [PATCH] vfio: fix virtio-pci dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527624BE8A9A0ACC3E97F1C28C692@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Wed, 10 Jan 2024 02:57:55 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Yishai Hadas <yishaih@...dia.com>, "Alex
 Williamson" <alex.williamson@...hat.com>, "Michael S. Tsirkin"
	<mst@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>
CC: Arnd Bergmann <arnd@...db.de>, Shameer Kolothum
	<shameerali.kolothum.thodi@...wei.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "virtualization@...ts.linux-foundation.org"
	<virtualization@...ts.linux-foundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] vfio: fix virtio-pci dependency

> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Tuesday, January 9, 2024 3:57 PM
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The new vfio-virtio driver already has a dependency on
> VIRTIO_PCI_ADMIN_LEGACY,
> but that is a bool symbol and allows vfio-virtio to be built-in even if
> virtio-pci itself is a loadable module. This leads to a link failure:
> 
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_probe':
> main.c:(.text+0xec): undefined reference to `virtio_pci_admin_has_legacy_io'
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_init_device':
> main.c:(.text+0x260): undefined reference to
> `virtio_pci_admin_legacy_io_notify_info'
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_bar0_rw':
> main.c:(.text+0x6ec): undefined reference to
> `virtio_pci_admin_legacy_common_io_read'
> aarch64-linux-ld: main.c:(.text+0x6f4): undefined reference to
> `virtio_pci_admin_legacy_device_io_read'
> aarch64-linux-ld: main.c:(.text+0x7f0): undefined reference to
> `virtio_pci_admin_legacy_common_io_write'
> aarch64-linux-ld: main.c:(.text+0x7f8): undefined reference to
> `virtio_pci_admin_legacy_device_io_write'
> 
> Add another explicit dependency on the tristate symbol.
> 
> Fixes: eb61eca0e8c3 ("vfio/virtio: Introduce a vfio driver over virtio devices")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>