[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240110191900.GM1315173@hu-bjorande-lv.qualcomm.com>
Date: Wed, 10 Jan 2024 11:19:00 -0800
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: Zhenhua Huang <quic_zhenhuah@...cinc.com>
CC: <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<conor+dt@...nel.org>, <linux-mtd@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<quic_tingweiz@...cinc.com>
Subject: Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from
mtd.yaml
On Wed, Jan 10, 2024 at 07:21:45PM +0800, Zhenhua Huang wrote:
> The mtd binding is always $ref'ed by other bindings, default selector
> should be from other binding files which ref'ed it. Now, "$nodename" in
> mtd.yaml turns into a "select" automatically such that a few binding check
> issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> rules in folder sram/*)
>
> To avoid the automatically created "select" in mtd.yaml, adding:
>
> select: false
>
> Suggested-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@...cinc.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> ---
> Hi Bjorn,
>
> As the idea is from your comment, I added "Suggested-by" you.
> Please tell me if that's not suitable. Thanks.
I appreciate that, thank you.
Regards,
Bjorn
>
> Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index f322290..ee442ec 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -10,6 +10,8 @@ maintainers:
> - Miquel Raynal <miquel.raynal@...tlin.com>
> - Richard Weinberger <richard@....at>
>
> +select: false
> +
> properties:
> $nodename:
> pattern: "^(flash|.*sram|nand)(@.*)?$"
> --
> 2.7.4
>
Powered by blists - more mailing lists