lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date: Wed, 10 Jan 2024 11:06:04 +0800
From: kernel test robot <lkp@...el.com>
To: Brian King <brking@...ux.vnet.ibm.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Damien Le Moal <dlemoal@...nel.org>,
	John Garry <john.g.garry@...cle.com>
Subject: drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used

Hi Brian,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ab27740f76654ed58dd32ac0ba0031c18a6dea3b
commit: 65a15d6560dff065339f6cac91de4beded60fe3f scsi: ipr: Remove SATA support
date:   9 months ago
config: i386-buildonly-randconfig-002-20240107 (https://download.01.org/0day-ci/archive/20240110/202401101004.fcxlPdWI-lkp@intel.com/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240110/202401101004.fcxlPdWI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401101004.fcxlPdWI-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/scsi/ipr.c:1104:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
    1104 |         unsigned int proto;
         |                      ^
   drivers/scsi/ipr.c:1261:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
    1261 |         unsigned int proto;
         |                      ^
   drivers/scsi/ipr.c:4417:29: warning: variable 'res' set but not used [-Wunused-but-set-variable]
    4417 |         struct ipr_resource_entry *res;
         |                                    ^
>> drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used [-Wunused-but-set-variable]
    5430 |         u32 ioasc;
         |             ^
   4 warnings generated.


vim +/ioasc +5430 drivers/scsi/ipr.c

3feeb89d40cc0ab Wayne Boyer                 2009-10-20  5426  
b53d124a154d002 wenxiong@...ux.vnet.ibm.com 2013-01-11  5427  static int ipr_process_hrrq(struct ipr_hrr_queue *hrr_queue, int budget,
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5428  						struct list_head *doneq)
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5429  {
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11 @5430  	u32 ioasc;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5431  	u16 cmd_index;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5432  	struct ipr_cmnd *ipr_cmd;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5433  	struct ipr_ioa_cfg *ioa_cfg = hrr_queue->ioa_cfg;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5434  	int num_hrrq = 0;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5435  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5436  	/* If interrupts are disabled, ignore the interrupt */
56d6aa33d3f6847 wenxiong@...ux.vnet.ibm.com 2013-01-11  5437  	if (!hrr_queue->allow_interrupts)
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5438  		return 0;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5439  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5440  	while ((be32_to_cpu(*hrr_queue->hrrq_curr) & IPR_HRRQ_TOGGLE_BIT) ==
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5441  	       hrr_queue->toggle_bit) {
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5442  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5443  		cmd_index = (be32_to_cpu(*hrr_queue->hrrq_curr) &
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5444  			     IPR_HRRQ_REQ_RESP_HANDLE_MASK) >>
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5445  			     IPR_HRRQ_REQ_RESP_HANDLE_SHIFT;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5446  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5447  		if (unlikely(cmd_index > hrr_queue->max_cmd_id ||
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5448  			     cmd_index < hrr_queue->min_cmd_id)) {
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5449  			ipr_isr_eh(ioa_cfg,
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5450  				"Invalid response handle from IOA: ",
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5451  				cmd_index);
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5452  			break;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5453  		}
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5454  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5455  		ipr_cmd = ioa_cfg->ipr_cmnd_list[cmd_index];
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5456  		ioasc = be32_to_cpu(ipr_cmd->s.ioasa.hdr.ioasc);
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5457  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5458  		ipr_trc_hook(ipr_cmd, IPR_TRACE_FINISH, ioasc);
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5459  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5460  		list_move_tail(&ipr_cmd->queue, doneq);
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5461  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5462  		if (hrr_queue->hrrq_curr < hrr_queue->hrrq_end) {
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5463  			hrr_queue->hrrq_curr++;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5464  		} else {
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5465  			hrr_queue->hrrq_curr = hrr_queue->hrrq_start;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5466  			hrr_queue->toggle_bit ^= 1u;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5467  		}
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5468  		num_hrrq++;
b53d124a154d002 wenxiong@...ux.vnet.ibm.com 2013-01-11  5469  		if (budget > 0 && num_hrrq >= budget)
b53d124a154d002 wenxiong@...ux.vnet.ibm.com 2013-01-11  5470  			break;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5471  	}
b53d124a154d002 wenxiong@...ux.vnet.ibm.com 2013-01-11  5472  
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5473  	return num_hrrq;
05a6538a9a20499 wenxiong@...ux.vnet.ibm.com 2013-01-11  5474  }
b53d124a154d002 wenxiong@...ux.vnet.ibm.com 2013-01-11  5475  

:::::: The code at line 5430 was first introduced by commit
:::::: 05a6538a9a204999e0c0f7faee00b81b334f4fc7 [SCSI] ipr: Add support for MSI-X and distributed completion

:::::: TO: wenxiong@...ux.vnet.ibm.com <wenxiong@...ux.vnet.ibm.com>
:::::: CC: James Bottomley <JBottomley@...allels.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ